New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to add a custom font source ? #21

Open

CharlonTank opened this issue Apr 18, 2018 · 1 comment

Collaborator

CharlonTank commented Apr 18, 2018 •

edited

type CustomFontFamily
    = SystemFont String
    | CustomFont String

As I see, we can't set a source on CustomFont
I want to add a src kinda like this :

  font-family: 'SF Pro Display';
  src: asset-url('fonts/SF-Pro-Display-Black.otf')

Which I assume will be :

type CustomFontFamily
    = SystemFont String
    | CustomFont String **(Maybe String)**

with Maybe String corresponding to the URL source of the font

The text was updated successfully, but these errors were encountered:

Contributor

tibastral commented Apr 18, 2018

Ok, you can implement it, and we'll merge it. No problem. And you are right, it should be like you say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment