Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved acceptor pool #80

Open
tsloughter opened this issue Jan 25, 2020 · 2 comments
Open

Improved acceptor pool #80

tsloughter opened this issue Jan 25, 2020 · 2 comments

Comments

@tsloughter
Copy link
Member

I've wanted to bring this up for a while and just realized I have a perfect PR on another project that shows what I'd want to do, so I'm opening this with https://github.com/adoptingerlang/service_discovery/pull/9/files

The reason I've been hesitant to bring it up is Elli currently has no dependencies and I'd expect adding a dependency would be controversial because of that.

The dependency would be https://github.com/fishcakez/acceptor_pool/

What it brings to Elli you can see if you look at the PR and how the pool and listen socket are started separately (in that order) allowing for shutdown to first close the listen socket, preventing new requests, and then (with an optional grace period) shutdown the other connections.

@tsloughter
Copy link
Member Author

I need to write examples to actually test this with Elli but acceptor_pool is also supposed to be built for release upgrades to work properly.

@yurrriq
Copy link
Member

yurrriq commented Jan 29, 2020

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants