Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Nx.LinAlg.lu to optional callback #1388

Open
polvalente opened this issue Dec 3, 2023 · 2 comments
Open

Convert Nx.LinAlg.lu to optional callback #1388

polvalente opened this issue Dec 3, 2023 · 2 comments
Assignees
@polvalente
Labels
area:exla Applies to EXLA area:nx Applies to nx kind:feature New feature or request

Comments

@polvalente
Copy link
Contributor

XLA doesn't provide an implementation, and we use LU decomposition for determinant, which is used in some other LinAlg functions.
Therefore, we should either look into JAX's implementation or just translate the BinaryBackend one to a defn, like we did with SVD.

This will also enable LU on MLIR by default.
@polvalente polvalente added kind:feature New feature or request area:exla Applies to EXLA area:nx Applies to nx labels Dec 3, 2023
@josevalim
Copy link
Collaborator

We can start with the translation, I think that's the simplest, and then explore other routes if necessary!

@polvalente
Copy link
Contributor Author

Agreed!

@polvalente polvalente self-assigned this Dec 3, 2023
@polvalente polvalente changed the title Reimplement Nx.LinAlg.lu as an optional callback Convert Nx.LinAlg.lu to optional callback Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@polvalente polvalente

Labels
area:exla Applies to EXLA area:nx Applies to nx kind:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josevalim @polvalente