Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOCAL INFILE #9

Closed
wojtekmach opened this issue Oct 23, 2018 · 3 comments
Closed

LOCAL INFILE #9

wojtekmach opened this issue Oct 23, 2018 · 3 comments
Labels
help wanted Kind:Feature

Comments

@wojtekmach
Copy link
Member

https://dev.mysql.com/doc/internals/en/com-query-response.html#packet-Protocol::LOCAL_INFILE_Data
@wojtekmach
Copy link
Member Author

Ref:
https://gwillem.gitlab.io/2019/01/20/sites-hacked-via-mysql-protocal-flaw/

@rliebling rliebling mentioned this issue May 10, 2020
Closed
@rliebling
Copy link

I took a stab at a safe implementation here. Welcome any feedback.

One potentially controversial decision i made was to ignore the actual filepath specified in the SQL (and then passed by the server back to the client when asking for the data). Instead, i require that the SQL request involving a LOCAL INFILE explicitly supply the data to send the server. I believe this addresses the security concerns, but at some inconvenience to the user.

@wojtekmach
Copy link
Member Author

Closing in favour of the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Kind:Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support LOAD DATA LOCAL INFILE operations rliebling/myxql
2 participants
@rliebling @wojtekmach