Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bolding, italicizing, underlining, and strike-troughing text #65

Merged
merged 15 commits into from Aug 23, 2019
Merged

Support bolding, italicizing, underlining, and strike-troughing text #65

merged 15 commits into from Aug 23, 2019

Conversation

ryonakano
Copy link
Member

@ryonakano ryonakano commented Jun 24, 2019 •
edited

Fixes #48 (part 1)

Screenshot from 2019-08-23 23-02-43

Changes Summary

  • Allow to bold text
  • Allow to italicize text
  • Allow to underline text
  • Allow to strike-trough text

TODO (in other PRs)

  • Allow to change font
  • Allow to change font size
  • Allow to change text alignment

@ryonakano
Copy link
Member Author

I decided to implement just bolding, italicizing, underlining, and strike-troughing text in this PR to keep going.

@ryonakano ryonakano marked this pull request as ready for review August 23, 2019 14:06
elegaanz
elegaanz approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not saved, but I guess it is because only CSV is supported at the moment. Works as expected otherwise!

@ryonakano ryonakano changed the title Support changing text style Support bolding, italicizing, underlining, and strike-troughing text Aug 23, 2019
@ryonakano ryonakano merged commit 0a5c887 into master Aug 23, 2019
@ryonakano ryonakano deleted the text-style branch August 23, 2019 14:44
@ryonakano ryonakano mentioned this pull request Aug 23, 2019
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elegaanz elegaanz elegaanz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support changing text style
2 participants
@ryonakano @elegaanz