Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View last viewed interactive page if Onboarding was closed without completion #127

Closed
wants to merge 10 commits into from
Closed

View last viewed interactive page if Onboarding was closed without completion #127

wants to merge 10 commits into from

Conversation

pongloongyeat
Copy link
Member

@pongloongyeat pongloongyeat commented Apr 13, 2021 •
edited

Possible solution to close #79. This PR is incomplete but I would like input from @elementary/ux first before proceeding further.

screen-capture.mp4

This PR does the following:

  • Quits the app on CTRL+q, which is the standard application quitting key.
  • If at anytime the app quits when not all pages are viewed, the app sends a notification that onboarding has not yet been completed.
  • Upon re-opening the onboarding app, it jumps to the first-most "interactive" page (i.e. page with switches, checkboxes, etc.)

TODOs:

  • Show the close button on the window (would need some small margin changes since headerbar does take up some amount of space introduces additional 10px height)
  • Should the "finished" key be used as a check or should "appcenter" be used since one could view the "appcenter" page and then quit, and it might show the notification on quit when it shouldn't.

@pongloongyeat pongloongyeat requested a review from a team April 13, 2021 06:30
@pongloongyeat
Copy link
Member Author

As of e88b367, please take note that there is an additional 10px height (headerbar height is 32px, original AbstractOnboardingView has a top margin of 22px, which is now set to 0px).

@pongloongyeat pongloongyeat changed the title Experimental: View last viewed interactive page if Onboarding was closed without completion View last viewed interactive page if Onboarding was closed without completion Apr 13, 2021
@jeremypw
Copy link
Collaborator

jeremypw commented Dec 6, 2023

CLosing as not reviewed/actioned after 2+yrs and conflicts

@jeremypw jeremypw closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Conflicts with master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip onboarding with the "Esc" key. Better keyboard navigation.
2 participants
@pongloongyeat @jeremypw