Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add settings links #29

Closed
wants to merge 10 commits into from
Closed

Add settings links #29

wants to merge 10 commits into from

Conversation

cassidyjames
Copy link
Contributor

@cassidyjames cassidyjames commented Apr 17, 2019 •
edited

Fixes #28. Not sure about styling, or if this is being too clever.

@danirabbit
Copy link
Member

Hm yeah this feels a little heavy visually. I wonder if something more subtle maybe with the path as a tooltip would be better?

@cassidyjames cassidyjames changed the title Initial adding of settings links Add settings links Apr 18, 2019
@cassidyjames
Copy link
Contributor Author

Current state
image

image

@cassidyjames cassidyjames requested a review from a team July 16, 2019 19:03
@cassidyjames cassidyjames added the Needs Design Waiting for input from the UX team label Nov 15, 2019
@cassidyjames cassidyjames mentioned this pull request Jun 29, 2020
Merged
@cassidyjames
Copy link
Contributor Author

I think a better approach is more contextual links when we want them, like the new "Adjust schedule and temperature..." link in the Night Light view.

@danirabbit danirabbit deleted the settings-links branch July 23, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit Awaiting requested review from danirabbit

Assignees
No one assigned
Labels
Needs Design Waiting for input from the UX team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add links to settings below inline controls
2 participants
@cassidyjames @danirabbit