Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters are not applied to window screenshots #1680

Open
lenemter opened this issue Jun 8, 2023 · 3 comments
Open

Filters are not applied to window screenshots #1680

lenemter opened this issue Jun 8, 2023 · 3 comments
Labels
Priority: Medium Should be addressed when time allows Status: Confirmed Verified by someone other than the reporter

Comments

@lenemter
Copy link
Member

lenemter commented Jun 8, 2023

What Happened?

When screenshoting a window with enabled filters, screenshots doesn't reflect the filter.

Steps to Reproduce

  1. Turn on any filter (e.g. grayscale)
  2. Screenshot a window

Expected Behavior

Screenshot with a filter.

OS Version

7.x (Horus)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

@lenemter lenemter added the Needs Design Waiting for input from the UX team label Jun 8, 2023
@danirabbit
Copy link
Member

I don’t think this is a bug. I think it’s a feature. I’m not sure there’s really value in having these filters applied to a screenshot since it’s your personal accommodation

@lenemter
Copy link
Member Author

lenemter commented Jun 8, 2023

I don’t think this is a bug. I think it’s a feature. I’m not sure there’s really value in having these filters applied to a screenshot since it’s your personal accommodation

But filters are applied to screen screenshots currently. Should we disable this behaviour then?

@tintou
Copy link
Member

tintou commented Jun 8, 2023

The filter shouldn't be applied to the screenshot content, otherwise:

  • Other people will see that you have a filter enabled if you share the image, and that's none of their business
  • We end-up with the filter being applied twice if we then view the screenshot with the same filter

@lenemter lenemter added Priority: Medium Should be addressed when time allows Status: Confirmed Verified by someone other than the reporter and removed Needs Design Waiting for input from the UX team labels Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Should be addressed when time allows Status: Confirmed Verified by someone other than the reporter
Projects
None yet
Development

No branches or pull requests

3 participants