Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on % input #133

Open
cassidyjames opened this issue Jun 2, 2020 · 4 comments
Open

Warn on % input #133

cassidyjames opened this issue Jun 2, 2020 · 4 comments

Comments

@cassidyjames
Copy link
Contributor

cassidyjames commented Jun 2, 2020

To solve issues like #44, we could throw an infobar letting the user know that % is ambiguous, and to try multiplying by a decimal instead to be more clear.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@cassidyjames
Copy link
Contributor Author

An alternative: we could just not accept % as valid input due to the ambiguity. Probably simpler, but might be less clear.

@jeremypw
Copy link
Collaborator

@cassidyjames Does the linked PR make any sense at all as a way of addressing this issue? Or would throwing a dialog or ignoring as invalid be preferable?

@cassidyjames
Copy link
Contributor Author

@jeremypw I think the linked PR tries to invent new operators which are going to be unfamiliar to most, and still ambiguous if you don't know how they work. I would prefer just not accepting % inputs, honestly.

@jeremypw
Copy link
Collaborator

No problem - I'll close that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants