Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking buttons that insert multi byte utf-8 characters makes the cursor skip positions #107

Open
santileortiz opened this issue Sep 8, 2019 · 0 comments

Comments

@santileortiz
Copy link
Collaborator

Pressing buttons for ×, ÷, −, √ and π while in the middle of a number is broken, it makes the cursor move ahead from it's actual position.

The reason is these are Unicode characters that get encoded into a multi byte string, then we increase the cursor position by the number of bytes not the number of Unicode characters.

Note that we can't just increase by 1 always, because trigonometric functions do contain multiple Unicode characters.

jeremypw pushed a commit that referenced this issue Dec 10, 2019
* Move cursor by Unicode character count, not byte count. (#107)

* Fix lint errors

* Start new release appdata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant