Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculator plugin: Method of copying the result not easily discoverable #412

Closed
1 task done
jeremypw opened this issue Sep 4, 2020 · 5 comments
Closed
1 task done
Labels
Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix. Hacktoberfest Used in the month of October for good issues for new contributors Priority: Wishlist Not a priority, but something that might be nice Status: Confirmed Verified by someone other than the reporter

Comments

@jeremypw
Copy link
Collaborator

jeremypw commented Sep 4, 2020

I have searched open and closed issues for duplicates.

Describe the bug

The result given by the calculator plugin cannot be selected or copied (at least, the obvious methods do not work), limiting its usefulness.

To Reproduce

Steps to reproduce the behavior:

  1. Open the Applications Menu
  2. Type a calculation in the search bar
  3. The result appears in the app list , next to the calculator icon
  4. The result cannot be selected or copied with the keyboard shortcut when the line is focused. Activating the line appears to do nothing (calculator does not open) but in fact the result is copied to the clipboard.

Expected behavior

Some indication of how to copy the result should appear e.g. as a placeholder or in the tooltip.

image

  • I'm using the latest Odin version

Additional context

Running a VM

@cassidyjames
Copy link
Contributor

cassidyjames commented Sep 4, 2020

Appending something to the result might make sense, like

12345 - Copy result to clipboard

@cassidyjames cassidyjames added Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix. Priority: Wishlist Not a priority, but something that might be nice Status: Confirmed Verified by someone other than the reporter labels Sep 4, 2020
@jeremypw
Copy link
Collaborator Author

jeremypw commented Sep 5, 2020

That could work except "select" is somewhat ambiguous in this context. It could mean "select the text" - which is what I initially tried to do. I only discovered by chance that pressing enter or clicking on the item copied the answer to the clipboard as well as closing the menu.

@cassidyjames cassidyjames added the Hacktoberfest Used in the month of October for good issues for new contributors label Nov 4, 2020
@cassidyjames cassidyjames pinned this issue Nov 4, 2020
@Eldhrimer
Copy link

I was looking bitsized issues to fix and this appear to be already fixed. This issue should be closed.

@jeremypw
Copy link
Collaborator Author

Thanks. The PR was not properly linked to this issue so it did not automatically close.

@ryonakano ryonakano unpinned this issue May 19, 2024
@ryonakano
Copy link
Contributor

Unpinning since this issue has been already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix. Hacktoberfest Used in the month of October for good issues for new contributors Priority: Wishlist Not a priority, but something that might be nice Status: Confirmed Verified by someone other than the reporter
Projects
None yet
Development

No branches or pull requests

4 participants