Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some pool names are not supported #163

Open
Phsacar opened this issue Apr 28, 2024 · 0 comments
Open

Some pool names are not supported #163

Phsacar opened this issue Apr 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Phsacar
Copy link

Phsacar commented Apr 28, 2024

Describe the bug

Some pool names cant be interpreted when parsing the benji.yaml

To Reproduce

Create a ceph pool that has underscores in its pool name. And configure it in the ios section.
Try to do a backup :)

Expected behavior

All pool names that are allowed in ceph should work in benji - although that could be hard to implement currently.

Platform and versions (please complete the following information):

Latest Helm chart ( as of 04 2024 )
Doesn't matter

Additional context

Hi,
additional info:
Bug is in "/src/benji/io/factory.py" (currently line 68): name = parsed_url.scheme
The problem is that when your "url" has an underscore in its scheme, python does not interpret it as a scheme anymore and sets it to "None".
For example data_pool:stuff/stuff wont work for backups, as data_pool would not be interpreted as a scheme. However if I used data-pool it works.
Also I fear that a ":" is also allowed in Ceph - that would break the entire URL scheme. ( I am not sure on this and didn't test it )

Thanks!

@Phsacar Phsacar added the bug Something isn't working label Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant