Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a build error when the configuration file on window is ts #8212

Closed
just-ads opened this issue May 11, 2024 · 3 comments · Fixed by develar/read-config-file#19 or #8216
Closed

Comments

@just-ads
Copy link

  • Electron-Builder Version: ^24.13.3
  • Node Version: v20.11.0
  • Electron Version:^30.0.3
  • Electron Type (current, beta, nightly):current
  • Target: win

1715398025720

It may be because platform.name in defaultOutDir in the loadTSConfig file is not the correct value.
It actually returns platform, and does not return win32 as expected.
image
Should os.platform() be used?
image

@mmaietta
Copy link
Collaborator

Blocked by mighdoll/config-file-ts#22

@just-ads
Copy link
Author

just-ads commented May 14, 2024

Blocked by mighdoll/config-file-ts#22

config-file-ts Looks to have fixed this bug. Fixed platform selection in loadTsConfig.ts
However, the read-config-file dependency used by electron-builder has not updated the config-file-ts dependency.
This library seems to be unmaintained? It was last updated two years ago.

@mmaietta
Copy link
Collaborator

Looks like there's a dependency in between. I've opened up a PR with that project, read-config-file develar/read-config-file#19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants