Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

support --disk-cache-size flag #290

Open
cjld opened this issue Apr 25, 2017 · 2 comments
Open

support --disk-cache-size flag #290

cjld opened this issue Apr 25, 2017 · 2 comments
Labels
enhancement

Comments

@cjld
Copy link

cjld commented Apr 25, 2017

I find out that the implementation of CreateHttpCacheBackendFactory, does not use the switch (--disk-cache-size=...), it set the cache size to zero, cause the cache size caculate by net::HttpCache::DefaultBackend and ignore the switch.
@deepak1556
Copy link
Contributor

--disk-cache-size is a chrome specific flag and hence wasn't implemented by default. There was already request in Electron for this flag electron/electron#7713 . If you are interested to implement it, feel free to send a PR. Thanks!

@deepak1556 deepak1556 changed the title switch --disk-cache-size not work, CreateHttpCacheBackendFactory does not use disk cache size switch(--disk-cache-size=...) support --disk-cache-size flag Apr 25, 2017
@deepak1556 deepak1556 mentioned this issue Apr 25, 2017
Closed
cjld added a commit to cjld/brightray that referenced this issue Apr 26, 2017
@cjld
support --disk-cache-size flag electron-archive#290
0e43d0a
@cjld
Copy link
Author

cjld commented Apr 26, 2017

It is worked for me.
hope this PR could help!

@kevinsawicki kevinsawicki mentioned this issue May 11, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deepak1556 @cjld