Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip overflows behind the top of the screen #6203

Closed
corradio opened this issue Nov 30, 2023 · 2 comments · Fixed by #6359
Closed

Tooltip overflows behind the top of the screen #6203

corradio opened this issue Nov 30, 2023 · 2 comments · Fixed by #6359
Labels
bug 🐞 frontend 🎨

Comments

@corradio
Copy link
Member

Describe the bug
Tooltip goes out of bound

To Reproduce
Steps to reproduce the behavior:

  1. Click on a country
  2. Scroll the country panel down
  3. However on a production mode high up on the screen

Expected behavior
Tooltip should not overflow behind the top of the screen

Screenshots
image

Desktop (if relevant):

  • OS: MacOS
  • Browser Chrome
  • Version [e.g. 22]
@PmplCode
Copy link
Contributor

Hello,

I'm new to open source contributions, but I believe I've identified a potential solution for this bug. Could you please guide me on the best way to share my proposed solution with the team?

Thanks, and I appreciate the opportunity to contribute to this great project!

PmplCode added a commit to PmplCode/electricitymaps-contrib that referenced this issue Jan 17, 2024
@PmplCode
FIX bug electricitymaps#6203 tooltip overflows behind screen: on BarB…
be2749e 
…reakdownChart.tsx i've managed to, on desktop, get height of header and place a limit to position y of the tooltip so it can not go further. further. On AreaGraphTooltip the same solution does not work so i placed a fixed value on desktop.
PmplCode added a commit to PmplCode/electricitymaps-contrib that referenced this issue Jan 17, 2024
@PmplCode
FIX bug electricitymaps#6203 tooltip overflows behind screen: AreaGra…
18b428a 
…phTooltip also fixed, now working as the BarBreakdownChart toolkit.
@PmplCode PmplCode mentioned this issue Jan 17, 2024
Merged
2 tasks
@corradio
Copy link
Member Author

corradio commented May 27, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 frontend 🎨
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 6203 tooltip overflows behind screen PmplCode/electricitymaps-contrib
2 participants
@corradio @PmplCode