Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Browser project monitors] No option for overwriting namespace #697

Open
dominiqueclarke opened this issue Feb 6, 2023 · 4 comments
Open
Labels
bug Something isn't working Team:Uptime Label for the Uptime team

Comments

@dominiqueclarke
Copy link
Contributor

Monitor namespace by default is the Kibana space the monitor was created in.

For UI monitors, the namespace can be overwritten per the user's specifications in the Add/Edit monitor flow.

However, there is no way to overwrite the namespace for browser project monitors.

We should update the types for the monitor configuration, found here, so that namespace can be added to monitor.use without type errors.

I believe we may need a change on the Kibana side as well to support namespace from browser project monitors. Further investigation is needed.

@dominiqueclarke dominiqueclarke added bug Something isn't working Team:Uptime Label for the Uptime team v8.7.0 labels Feb 6, 2023
dominiqueclarke added a commit to elastic/kibana that referenced this issue Feb 8, 2023
## Summary

Relates to elastic/synthetics#697

Allows custom namespaces for project monitors.

Returns an error when the custom namepsace defined is not
fleet-compliant.
@paulb-elastic
Copy link
Contributor

Kibana work done in elastic/kibana#150388, this will be end-to-end tested when this Synthetics Agent change is implemented

@vigneshshanmugam
Copy link
Member

vigneshshanmugam commented Apr 25, 2023

Should this be under data_stream.namespace instead of top level? Same feature has been asked here - #749

@vigneshshanmugam
Copy link
Member

Discussed on slack, namespace fields under Monitor DSL as topelvel is not extensible given we might want to support data_stream.type and data_stream_dataset. Plus, if we start supporting the namespaces for Lightweight monitors which we likely fix it in next iterations, It would create double work on the agent side and create more confusion as they are in different levels.

Blocking this issue off till necessary Kibana changes are done.
/cc @paulb-elastic

@mholttech
Copy link

I just came across this and was wondering when this will be implemented since the upstream work in Kibana is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Team:Uptime Label for the Uptime team
Projects
None yet
Development

No branches or pull requests

4 participants