Cleanup aiAssistantFlyoutMode feature flag #182992
Open
+805
−2,616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
…-modal-cleanup # Conflicts: # x-pack/plugins/security_solution/public/attack_discovery/pages/header/index.tsx
|
/ci |
patrykkopycinski
changed the title
|
/ci |
|
/ci |
…cinski/kibana into chore/assistant-modal-cleanup
|
/ci |
…-modal-cleanup # Conflicts: # x-pack/packages/kbn-elastic-assistant/impl/assistant/index.tsx
|
/ci |
|
/ci |
…-modal-cleanup # Conflicts: # x-pack/packages/kbn-elastic-assistant/impl/assistant/assistant_header/assistant_header_flyout.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/index.tsx
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
patrykkopycinski
added
release_note:skip
| @@ -218,14 +213,10 @@ describe('Assistant', () => { | |||
| ); | |||
| }); | |||
|
|
|||
| it('should delete conversation when delete button is clicked', async () => { | |||
| it.skip('should delete conversation when delete button is clicked', async () => { | |||
There was a problem hiding this comment.
supposed to be skipped?
| @@ -235,7 +226,7 @@ describe('Assistant', () => { | |||
| expect(mockDeleteConvo).toHaveBeenCalledWith(mockData.welcome_id.id); | |||
| }); | |||
| }); | |||
| describe('when selected conversation changes and some connectors are loaded', () => { | |||
| describe.skip('when selected conversation changes and some connectors are loaded', () => { | |||
PhilippeOberti
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup Security
aiAssistantFlyoutModefeature flag