Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/react 18 bump #182627

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

Chore/react 18 bump #182627

wants to merge 28 commits into from
+4,204 −3,093

Conversation

patrykkopycinski
Copy link
Contributor

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

patrykkopycinski and others added 21 commits May 2, 2024 11:59
@patrykkopycinski
Fix
fce7a1a
@patrykkopycinski
Merge branch 'main' of github.com:elastic/kibana into chore/react-18-…
b29f4d1 
…callback-any

# Conflicts:
#	x-pack/plugins/index_management/server/routes/api/component_templates/register_privileges_route.test.ts
#	x-pack/plugins/index_management/server/routes/api/enrich_policies/register_privileges_route.test.ts
#	x-pack/plugins/index_management/server/test/helpers/route_dependencies.ts
#	x-pack/plugins/lens/public/visualizations/partition/toolbar.tsx
@patrykkopycinski
Fix
257bb42
@patrykkopycinski
fix
3c309df
@semd
remove usages of any
fa09b52
@sebelga
Update packages/react/kibana_mount/utils.ts
4b6d049
@sebelga
Update x-pack/plugins/saved_objects_tagging/public/components/edition…
45f7bcb 
…_modal/utils.ts
@nickpeihl
Fixed usages of any in Presentation team code
d53441b
@nickpeihl
Merge remote-tracking branch 'refs/remotes/patrykkopycinski/chore/rea…
3700afd 
…ct-18-callback-any' into chore/react-18-callback-any
@stratoula
Remove anys from the esql editor code
8b7d093
@patrykkopycinski
Update experimental_features.ts
d2ebd76
@weltenwort
Replace anys with correct types in logs ui code
ee3e4b8
@nickofthyme
Replace any types in vis CO files
8fdb6b0
@davismcphee
Update Data Discovery types
dd67ecc
@davismcphee
More minor Data Discovery type changes
b850e7f
@davismcphee
Fix type in test
0ef027a
@vitaliidm
remove any type
08bdf45
@patrykkopycinski @maximpn
Apply suggestions from code review
a78cd4f 
Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
@patrykkopycinski
Merge branch 'main' of github.com:elastic/kibana into chore/react-18-…
94c65f6 
…callback-any

# Conflicts:
#	packages/kbn-text-based-editor/src/text_based_languages_editor.tsx
#	x-pack/plugins/lens/public/app_plugin/lens_top_nav.tsx
@patrykkopycinski
fix
8875823
@patrykkopycinski
test
1e6705b
@patrykkopycinski
Copy link
Contributor Author

/ci

@patrykkopycinski
Copy link
Contributor Author

/ci

@patrykkopycinski
Copy link
Contributor Author

/ci

@patrykkopycinski
Copy link
Contributor Author

/ci

@patrykkopycinski
Merge branch 'main' of github.com:elastic/kibana into chore/react-18-…
1236e9a 
…bump

# Conflicts:
#	src/plugins/discover/public/application/main/components/layout/discover_documents.tsx
#	x-pack/plugins/observability_solution/slo/public/pages/slo_details/components/history/slo_details_history.tsx
#	x-pack/plugins/security_solution/public/common/components/drag_and_drop/draggable_wrapper.tsx
#	x-pack/plugins/security_solution/public/common/components/hover_popover/hover_popover.tsx
#	x-pack/plugins/security_solution/public/explore/hosts/pages/details/index.tsx
#	x-pack/plugins/security_solution/public/explore/users/pages/details/index.tsx
#	x-pack/plugins/security_solution/public/flyout/document_details/preview/components/alert_reason_preview.test.tsx
#	x-pack/plugins/security_solution/public/flyout/document_details/right/components/event_renderer.test.tsx
#	x-pack/plugins/security_solution/public/overview/components/recent_timelines/recent_timelines.tsx
@patrykkopycinski
Copy link
Contributor Author

/ci

@patrykkopycinski
Copy link
Contributor Author

/ci

@patrykkopycinski
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 17, 2024 •
edited

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #8 / autohide footer functions on mouseEnter + Leave
  • [job] [logs] Jest Tests #8 / scrubber hides if open when autohide is activated
  • [job] [logs] Jest Tests #8 / metadata should be in readOnly mode by default
  • [job] [logs] Jest Tests #8 / metadata should display the "Update" button when not readOnly
  • [job] [logs] Jest Tests #8 / metadata should render the form with the provided item
  • [job] [logs] Jest Tests #8 / metadata should send back the updated item to the onSave() handler
  • [job] [logs] Jest Tests #8 / metadata should set the correct flyout title
  • [job] [logs] Jest Tests #8 / metadata should update the tag selection
  • [job] [logs] Jest Tests #8 / metadata should validate that the form is valid
  • [job] [logs] Jest Tests #11 / Render factory
  • [job] [logs] Jest Tests #8 / can navigate Autoplay Settings
  • [job] [logs] Jest Tests #8 / can navigate Toolbar Settings, closes when activated
  • [job] [logs] FTR Configs #5 / a11y tests using flights sample data Dashboard Delete a11y clone dashboard
  • [job] [logs] Jest Tests #5 / Chart render progress bar when text based and request is loading
  • [job] [logs] Jest Tests #5 / Chart render when chart is defined and onEditVisualization is defined
  • [job] [logs] Jest Tests #5 / Chart render when chart is defined and onEditVisualization is undefined
  • [job] [logs] Jest Tests #5 / Chart render when chart is undefined
  • [job] [logs] Jest Tests #5 / Chart render when chart.hidden is false
  • [job] [logs] Jest Tests #5 / Chart render when chart.hidden is true
  • [job] [logs] Jest Tests #5 / Chart render when is text based and not timebased
  • [job] [logs] Jest Tests #5 / Chart should not render when custom toggle is provided and chart is hidden
  • [job] [logs] Jest Tests #5 / Chart should render a custom toggle when provided
  • [job] [logs] Jest Tests #5 / Chart should render BreakdownFieldSelector when chart is visible and breakdown is defined
  • [job] [logs] Jest Tests #5 / Chart should render chart if data view is time based
  • [job] [logs] Jest Tests #5 / Chart should render the edit on the fly button when chart is visible and suggestions exist
  • [job] [logs] Jest Tests #5 / Chart should render the element passed to appendHistogram
  • [job] [logs] Jest Tests #5 / Chart should render the save button when chart is visible and suggestions exist
  • [job] [logs] Jest Tests #5 / Chart triggers onEditVisualization on click
  • [job] [logs] Jest Tests #7 / Control group component ensure actions get rendered
  • [job] [logs] Jest Tests #7 / control group renderer destroys control group container on unmount
  • [job] [logs] Jest Tests #6 / CreateCaseForm should render spinner when loading
  • [job] [logs] FTR Configs #97 / dashboard app - group 1 Changing field formatter to Url applied on dashboard
  • [job] [logs] FTR Configs #67 / dashboard app - group 5 dashboard settings "before all" hook for "should be able to hide all panel titles"
  • [job] [logs] FTR Configs #44 / Dashboard dashboard with async search not delayed should load
  • [job] [logs] FTR Configs #62 / dashboard feature controls dashboard feature controls security global dashboard all privileges, no embeddable application privileges does not allow a visualization to be edited
  • [job] [logs] Jest Tests #17 / dashboard renderer adds a class to apply default background color when dashboard has use margin option set to false
  • [job] [logs] Jest Tests #17 / dashboard renderer adds a class to the parent element when expandedPanelId is truthy
  • [job] [logs] Jest Tests #17 / dashboard renderer destroys dashboard container on unmount
  • [job] [logs] Jest Tests #17 / dashboard renderer renders a 404 page when dashboard navigation returns a savedObjectNotFound error
  • [job] [logs] Jest Tests #17 / dashboard renderer renders and destroys an error embeddable when the dashboard factory create method throws an error
  • [job] [logs] Jest Tests #17 / DashboardGrid removes panel when removed from container
  • [job] [logs] Jest Tests #17 / DashboardGrid renders expanded panel
  • [job] [logs] Jest Tests #17 / DashboardGrid renders focused panel
  • [job] [logs] Jest Tests #7 / Data control editor creating a new control selecting a number field when creating range slider, validates step setting is greater than 0
  • [job] [logs] FTR Configs #24 / discover Discover CSV Export Check Available "before all" hook for "is available if new"
  • [job] [logs] FTR Configs #14 / discover discover field visualize button should visualize correctly using adhoc data view
  • [job] [logs] FTR Configs #55 / discover feature controls discover feature controls security when has privileges to read data views but no privileges to read index allows to access only via a permitted index alias
  • [job] [logs] FTR Configs #19 / discover/ccs_compatible discover integration with data view editor allows creating a new data view
  • [job] [logs] FTR Configs #15 / discover/group1 discover histogram should update correctly when switching data views and brushing the histogram
  • [job] [logs] FTR Configs #30 / discover/group1 discover histogram should update correctly when switching data views and brushing the histogram
  • [job] [logs] FTR Configs #84 / discover/group1 discover histogram should update correctly when switching data views and brushing the histogram
  • [job] [logs] FTR Configs #35 / discover/group3 discover default columns should render only available default columns after switching data views
  • [job] [logs] FTR Configs #35 / discover/group3 discover default columns should render only available default columns after switching data views
  • [job] [logs] FTR Configs #81 / discover/group4 adhoc data views should navigate back correctly from to surrounding and single views
  • [job] [logs] FTR Configs #21 / discover/group6 discover sidebar field filtering should show filters by type in text-based view
  • [job] [logs] FTR Configs #21 / discover/group6 discover sidebar field filtering should show filters by type in text-based view
  • [job] [logs] FTR Configs #53 / discover/group7 indexpattern without timefield should adapt sidebar fields when switching
  • [job] [logs] Jest Tests #6 / Edit calls onSubmit when changing value
  • [job] [logs] Jest Tests #6 / Edit does not shows a validation error if the field is not required
  • [job] [logs] Jest Tests #6 / Edit reset to initial value when canceling
  • [job] [logs] Jest Tests #6 / Edit sets the value to null if the text field is empty
  • [job] [logs] Jest Tests #6 / EditConnector resets to the initial connector onCancel
  • [job] [logs] Jest Tests #17 / EntryContent should render a nested value
  • [job] [logs] Jest Tests #4 / FieldDescription should render correctly with a long custom description
  • [job] [logs] Jest Tests #4 / FieldDescriptionIconButton should render correctly with a long custom description
  • [job] [logs] Jest Tests #4 / FieldDescriptionIconButton should render correctly with a short custom description
  • [job] [logs] Jest Tests #6 / FileActionsPopoverButton clicking the copy file hash button rerenders the popover correctly
  • [job] [logs] Jest Tests #5 / FlyoutService openFlyout() with a currently active flyout replaces the current flyout with a new one
  • [job] [logs] FTR Configs #67 / graph app graph should open Graph workspace
  • [job] [logs] Jest Tests #7 / HeatmapComponent renders the legend toggle component if uiState is set
  • [job] [logs] Jest Tests #17 / install footer should render
  • [job] [logs] FTR Configs #91 / lens app - group 2 lens query context keeps selected index pattern after refresh
  • [job] [logs] FTR Configs #31 / lens app - group 3 lens add-to-dashboards tests should allow new lens be added by value to an existing dashboard
  • [job] [logs] FTR Configs #79 / lens app - group 4 show underlying data should show the underlying data extracting all filters and columns from a formula
  • [job] [logs] FTR Configs #80 / lens app - group 5 lens drag and drop tests dropping between layers should move formula to empty dimension
  • [job] [logs] FTR Configs #47 / lens app - group 6 lens disable auto-apply tests should apply changes when "Apply" is clicked
  • [job] [logs] FTR Configs #18 / lens serverless - group 1 lens tsdb downsampling for regular metric defaults to median for non-rolled up metric
  • [job] [logs] FTR Configs #28 / lens serverless - group 1 lens tsdb downsampling for regular metric defaults to median for non-rolled up metric
  • [job] [logs] FTR Configs #81 / machine learning - anomaly detection anomaly embeddables migration in Dashboard for ML anomaly swim lane loads saved dashboard from version 7.15.2
  • [job] [logs] FTR Configs #44 / machine learning - permissions for user with full ML access with data loaded (ft_ml_poweruser) should display elements on Calendar management page correctly
  • [job] [logs] FTR Configs #4 / maps app esql "before all" hook for "should display ES|QL statement results on map"
  • [job] [logs] FTR Configs #4 / maps app esql "before all" hook for "should display ES|QL statement results on map"
  • [job] [logs] FTR Configs #7 / maps app geojson vector layer - es geo grid source geo_point "before all" hook for "should re-fetch geotile_grid aggregation with refresh timer"
  • [job] [logs] FTR Configs #53 / maps app point to point source "before all" hook for "should request source clusters for destination locations"
  • [job] [logs] Jest Tests #5 / ModalService openConfirm() renders a mountpoint confirm message
  • [job] [logs] Jest Tests #5 / ModalService openConfirm() renders a string confirm message
  • [job] [logs] Jest Tests #5 / ModalService openConfirm() with a currently active confirm replaces the current confirm with the new one
  • [job] [logs] Jest Tests #5 / ModalService openConfirm() with a currently active modal replaces the current modal with the new confirm
  • [job] [logs] Jest Tests #5 / ModalService openModal() with a currently active confirm replaces the current confirm with the new one
  • [job] [logs] Jest Tests #5 / ModalService openModal() with a currently active modal replaces the current modal with a new one
  • [job] [logs] Jest Tests #8 / PartitionVisComponent renders the legend toggle component
  • [job] [logs] Jest Tests #11 / publishing subject render should render for each state update outside of click handler
  • [job] [logs] Jest Tests #17 / renders DashboardGrid with no visualizations
  • [job] [logs] Jest Tests #17 / SampleDataCard not installed renders
  • [job] [logs] FTR Configs #5 / saved objects tagging - functional tests table listing searching allows to search by name
  • [job] [logs] FTR Configs #6 / Saved query management Feature controls Security: App vs Global privilege dashboard read-only privileges with enabled savedQueryManagement.saveQuery privilege "before all" hook for "shows read-only badge"
  • [job] [logs] Jest Tests #17 / SearchBar chromeStyle: classic correctly filters and sorts results
  • [job] [logs] Jest Tests #17 / SearchBar chromeStyle: classic only display results from the last search
  • [job] [logs] Jest Tests #17 / SearchBar chromeStyle: classic tracks the user's search term
  • [job] [logs] FTR Configs #67 / Serverless Common UI - Management Index Management Index component templates "before each" hook for "renders the component templates tab"
  • [job] [logs] Jest Tests #17 / should render popover when appLinks is not empty
  • [job] [logs] Jest Tests #17 / should render popover with ordered appLinks
  • [job] [logs] Jest Tests #17 / should render simple button when appLinks is empty
  • [job] [logs] Jest Tests #11 / SolutionSideNav panel button toggle should close the panel when the same button is clicked
  • [job] [logs] Jest Tests #11 / SolutionSideNav panel button toggle should open other panel when other button is clicked while open
  • [job] [logs] Jest Tests #11 / SolutionSideNav panel button toggle should render the panel when button is clicked
  • [job] [logs] Jest Tests #5 / Test of helper / hook useEsDocSearch ignore partial results
  • [job] [logs] Jest Tests #4 / Transform: Job List Columns useColumns()
  • [job] [logs] Jest Tests #4 / Transform: Transform List Actions useActions()
  • [job] [logs] Jest Tests #4 / Transform: useIndexData() dataView set triggers loading
  • [job] [logs] Jest Tests #8 / TreeNav component collapses / expands the tree nav when clicking on collapse button
  • [job] [logs] Jest Tests #8 / TreeNav component shows the tree path according with the selected view type
  • [job] [logs] Jest Tests #6 / use cases add to existing case modal hook should throw if called outside of a cases context
  • [job] [logs] Jest Tests #7 / useAggregatedIndicators() should create and call the aggregatedIndicatorsQuery correctly
  • [job] [logs] Jest Tests #8 / useAlertsHistory calls http post including instanceId query
  • [job] [logs] Jest Tests #8 / useAlertsHistory calls http post without * instanceId query
  • [job] [logs] Jest Tests #8 / useAlertsHistory returns no data when API error
  • [job] [logs] Jest Tests #8 / useAlertsHistory returns no data with error when http client is not provided
  • [job] [logs] Jest Tests #8 / useAlertsHistory returns the alert history chart data
  • [job] [logs] Jest Tests #7 / useAssetCriticality useAssetCriticalityData calls create api when the mutation is called with assigned criticality level
  • [job] [logs] Jest Tests #7 / useAssetCriticality useAssetCriticalityData calls delete api when the mutation is called with unassigned criticality level
  • [job] [logs] Jest Tests #7 / useAssetCriticality useAssetCriticalityPrivileges calls privileges API when hasEntityAnalyticsCapability and UiSettings are enabled
  • [job] [logs] Jest Tests #7 / useAssetCriticality useAssetCriticalityPrivileges does not call privileges API when hasEntityAnalyticsCapability is false
  • [job] [logs] Jest Tests #7 / useAssetCriticality useAssetCriticalityPrivileges does not call privileges API when UI Settings is disabled
  • [job] [logs] Jest Tests #11 / useEmbeddableFactory should update upstream value changes
  • [job] [logs] Jest Tests #7 / useFindLists invokes Api.findLists
  • [job] [logs] Jest Tests #11 / useGrouping Renders child component with grouping table wrapper when group is selected
  • [job] [logs] Jest Tests #11 / useGrouping Renders child component without grouping table wrapper when no group is selected
  • [job] [logs] Jest Tests #7 / useIndicatorById() when mounted should create and call the indicatorsQuery
  • [job] [logs] Jest Tests #7 / useIndicators() when inputs change should query the database again and reset page to 0
  • [job] [logs] Jest Tests #7 / useIndicators() when mounted should create and call the indicatorsQuery
  • [job] [logs] Jest Tests #7 / useIntegrations should have undefined data during loading state
  • [job] [logs] Jest Tests #7 / useIntegrations should return integrations on success
  • [job] [logs] Jest Tests #7 / UseIsOsqueryAvailableSimple should expect response from API and return enabled flag
  • [job] [logs] Jest Tests #6 / useItemsAction flyout closes the flyout
  • [job] [logs] Jest Tests #6 / useItemsAction items calls fieldSelector correctly
  • [job] [logs] Jest Tests #6 / useItemsAction items calls itemsTransformer correctly
  • [job] [logs] Jest Tests #6 / useItemsAction items do not update cases with no changes
  • [job] [logs] Jest Tests #6 / useItemsAction items do not update if selecting and unselecting the same item
  • [job] [logs] Jest Tests #6 / useItemsAction items do not update if the selected items are the same
  • [job] [logs] Jest Tests #6 / useItemsAction items do not update if the selected items are the same but with different order
  • [job] [logs] Jest Tests #6 / useItemsAction items do not update with empty items and no selection
  • [job] [logs] Jest Tests #6 / useItemsAction items removes duplicates
  • [job] [logs] Jest Tests #6 / useItemsAction items shows the success toaster correctly when updating a case
  • [job] [logs] Jest Tests #6 / useItemsAction items update the items correctly
  • [job] [logs] Jest Tests #7 / useLoadConnectors handles errors correctly
  • [job] [logs] Jest Tests #7 / useLoadConnectors successfully loads and transforms connectors
  • [job] [logs] Jest Tests #7 / useManagementLink Hook generates the management link successfully
  • [job] [logs] Jest Tests #7 / usePolicies should have undefined data during loading state
  • [job] [logs] Jest Tests #7 / usePolicies should return policies on success
  • [job] [logs] Jest Tests #6 / usePushToService refresh case view page after push
  • [job] [logs] Jest Tests #7 / useRiskScore entityType: host return result
  • [job] [logs] Jest Tests #7 / useRiskScore entityType: user return result
  • [job] [logs] Jest Tests #8 / useWorkpad fires request to load workpad and dispatches results
  • [job] [logs] Jest Tests #8 / useWorkpad redirects on alias match
  • [job] [logs] Jest Tests #8 / useWorkpad sets alias id of workpad on a conflict
  • [job] [logs] Jest Tests #8 / useWorkpadPersist changes to workpad cause a workpad update
  • [job] [logs] FTR Configs #13 / visualize app - new charts library visualize area charts date histogram when no time filter interval errors should show error when calendar interval invalid
  • [job] [logs] FTR Configs #13 / visualize app - new charts library visualize area charts date histogram when no time filter interval errors should show error when calendar interval invalid
  • [job] [logs] FTR Configs #19 / visualize app Add to Dashboard adding a new metric to an existing dashboard by value

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet