Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embeddables Rebuild] O11y Migrate SLO Overview #179296

Closed
Tracked by #181409 ...
ThomThomson opened this issue Mar 22, 2024 · 2 comments · Fixed by #181930
Closed
Tracked by #181409 ...

[Embeddables Rebuild] O11y Migrate SLO Overview #179296

ThomThomson opened this issue Mar 22, 2024 · 2 comments · Fixed by #181930
Assignees
Labels
Feature:Embeddables Relating to the Embeddable system impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

As part of the Embeddable refactor, we will need to transition the SLO Overview Embeddable to the new framework.

This is located in:

x-pack/plugins/observability_solution/slo/public/embeddable/slo/overview/slo_embeddable_factory.ts

CC @mgiota

@ThomThomson ThomThomson added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Feature:Embeddables Relating to the Embeddable system labels Mar 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@mgiota
Copy link
Contributor

mgiota commented Apr 30, 2024

Once the panel placement registry work from @nickpeihl ends up on main, I will update my open PR!

mgiota added a commit that referenced this issue May 3, 2024
Fixes #179296

## 🍒 Summary

This PR converts the SLO Overview embeddable (Single SLO & Grouped SLOs)
to the new React Embeddable framework. There are no UI changes to the
current embeddable and the behavior should be the same. I have a video
of how the embeddable should work.



https://github.com/elastic/kibana/assets/2852703/d37c3f99-3140-4a09-a223-36a1d2242649

## ✔️ Acceptance criteria
- A new `create_overview_panel_action` action is created, which adds the
`SLO Overview` option in the Add panel section
- The `SLO Overview` menu option is grouped under SLOs menu
- Clicking on the single SLO card should open a Flyout with the SLO
details
- Clicking on the Grouped SLOs should expand the accordion and show the
SLOs that belong to this group
- The Grouped SLO have the `Edit criteria` option
- `Edit criteria` option appears under `More` panel options only for the
Grouped SLOs
- Kibana screenshot tool should report no timeout error.
- Clicking on the Refresh button should reload the embeddable
- We should be able to set default dimensions to the embeddable panels
cc @nickpeihl
  - Depends on #182120

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
yuliacech pushed a commit to yuliacech/kibana that referenced this issue May 3, 2024
Fixes elastic#179296

## 🍒 Summary

This PR converts the SLO Overview embeddable (Single SLO & Grouped SLOs)
to the new React Embeddable framework. There are no UI changes to the
current embeddable and the behavior should be the same. I have a video
of how the embeddable should work.



https://github.com/elastic/kibana/assets/2852703/d37c3f99-3140-4a09-a223-36a1d2242649

## ✔️ Acceptance criteria
- A new `create_overview_panel_action` action is created, which adds the
`SLO Overview` option in the Add panel section
- The `SLO Overview` menu option is grouped under SLOs menu
- Clicking on the single SLO card should open a Flyout with the SLO
details
- Clicking on the Grouped SLOs should expand the accordion and show the
SLOs that belong to this group
- The Grouped SLO have the `Edit criteria` option
- `Edit criteria` option appears under `More` panel options only for the
Grouped SLOs
- Kibana screenshot tool should report no timeout error.
- Clicking on the Refresh button should reload the embeddable
- We should be able to set default dimensions to the embeddable panels
cc @nickpeihl
  - Depends on elastic#182120

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Embeddables Relating to the Embeddable system impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants