Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serialization of put/delete shutdown requests #107862

Merged
merged 9 commits into from May 3, 2024
Merged

Fix serialization of put/delete shutdown requests #107862

merged 9 commits into from May 3, 2024

Conversation

DaveCTurner
Copy link
Contributor

Closes #107857

@DaveCTurner DaveCTurner added >bug :Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown v8.15.0 labels Apr 24, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Apr 24, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Hi @DaveCTurner, I've created a changelog YAML for you.

@DaveCTurner DaveCTurner changed the title Fix serialization of put-shutdown request Fix serialization of put/delete shutdown requests Apr 25, 2024
ldematte
ldematte approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecoop thecoop mentioned this pull request May 3, 2024
Merged
@thecoop thecoop mentioned this pull request May 3, 2024
Merged
@thecoop
Copy link
Member

thecoop commented May 3, 2024

8.13 and 8.14 backports are #108250 and #108251 respectively. Note the interdependent uses of the 8.13 and 8.14 transport patch versions

@ldematte
Copy link
Contributor

ldematte commented May 3, 2024

Still good after the backports

@thecoop
Copy link
Member

thecoop commented May 3, 2024

@elasticmachine update branch

@thecoop thecoop merged commit eb90e36 into elastic:main May 3, 2024
15 checks passed
thecoop added a commit that referenced this pull request May 3, 2024
@thecoop
Backport serialization fix of put/delete shutdown requests to 8.14 (#…
810e86b 
…108251)

Backport of #107862 to 8.14
thecoop added a commit that referenced this pull request May 3, 2024
@thecoop
Backport serialization fixes to 8.13 (#108250)
0fe59ca 
Backport of #107862 to 8.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldematte ldematte ldematte approved these changes

Assignees
No one assigned
Labels
>bug :Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown Team:Core/Infra Meta label for core/infra team v8.13.4 v8.14.0 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PutShutdownNodeAction.Request does not preserve parent task or timeouts on the wire
5 participants
@DaveCTurner @elasticsearchmachine @thecoop @ldematte @elasticmachine