Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Trained model size calculated incorrectly #107831

Open
davidkyle opened this issue Apr 24, 2024 · 1 comment
Open

[ML] Trained model size calculated incorrectly #107831

davidkyle opened this issue Apr 24, 2024 · 1 comment
Assignees
Labels
>bug :ml Machine learning Team:ML Meta label for the ML team

Comments

@davidkyle
Copy link
Member

davidkyle commented Apr 24, 2024

Elasticsearch Version

8.13.0

Installed Plugins

No response

Java Version

bundled

OS Version

any

Problem Description

The trained model stats incorrectly calculates the required_native_memory_bytes field.

Since #98139 calculating the model's required memory has taken into account the number of allocations as each allocation uses extra memory. The memory requirements for each deployment are different depending on the number of allocations. The bug is that the total number of deployed allocations is used to calculate the required memory rather than the deployment's number of allocations.

required_native_memory_bytes should be calculated per deployment using the correct number of allocations

The bug only affects the Stats API output it does not affect deploying a model

Steps to Reproduce

Deploy any 2 NLP model in machine learning. Change the number of allocations for the first model and observe the required memory change for second model.

Logs (if relevant)

No response

@davidkyle davidkyle added >bug :ml Machine learning labels Apr 24, 2024
@davidkyle davidkyle self-assigned this Apr 24, 2024
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Apr 24, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :ml Machine learning Team:ML Meta label for the ML team
Projects
None yet
Development

No branches or pull requests

2 participants