Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] More randomization for snapshot names #107884

Merged
merged 3 commits into from Apr 26, 2024

Conversation

ywangd
Copy link
Member

@ywangd ywangd commented Apr 25, 2024

Increase the randomization for snapshot names to avoid duplicates which fail to create map in test. See similar fix #101603

Resolves: #107816

Increase the randomization for snapshot names to avoid duplicates which
fail to create map in test. See similar fix elastic#101603

Resolves: elastic#107816
@ywangd ywangd added >test Issues or PRs that are addressing/adding tests :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.14.1 v8.15.0 labels Apr 25, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team label Apr 25, 2024
Copy link
Contributor

@idegtiarenko idegtiarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I wonder if we have more tests that have similar issue?

@ywangd
Copy link
Member Author

ywangd commented Apr 25, 2024

Not in this test class. But possibly somewhere else. It's hard to be sure. I guess we will have to wait for the failures to happen.

@ywangd ywangd added auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport-and-merge Automatically create backport pull requests and merge when ready labels Apr 25, 2024
@ywangd
Copy link
Member Author

ywangd commented Apr 25, 2024

@elasticmachine update branch

@ywangd
Copy link
Member Author

ywangd commented Apr 26, 2024

@elasticmachine update branch

@elasticsearchmachine elasticsearchmachine merged commit 0b747ac into elastic:main Apr 26, 2024
14 checks passed
@ywangd ywangd deleted the es-107816-random-name branch April 26, 2024 06:05
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Apr 26, 2024
Increase the randomization for snapshot names to avoid duplicates which
fail to create map in test. See similar fix elastic#101603

Resolves: elastic#107816
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.14

elasticsearchmachine pushed a commit that referenced this pull request Apr 26, 2024
Increase the randomization for snapshot names to avoid duplicates which
fail to create map in test. See similar fix #101603

Resolves: #107816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Meta label for distributed team >test Issues or PRs that are addressing/adding tests v8.14.1 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] SnapshotRetentionConfigurationTests testPartialsNotCountedTowardsMaximum failing
4 participants