Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pull Request Labeler #8054

Open
gpetrou opened this issue Mar 8, 2024 · 1 comment
Open

Use Pull Request Labeler #8054

gpetrou opened this issue Mar 8, 2024 · 1 comment

Comments

@gpetrou
Copy link
Contributor

gpetrou commented Mar 8, 2024

Is your feature request related to a problem? Please describe.
Currently, https://github.com/banyan/auto-label is used which seems to be outdated and produces an action error.
For example, https://github.com/elastic/elasticsearch-net/actions/runs/8183925897/job/22388312350?pr=8053.

Describe the solution you'd like
Use https://github.com/actions/labeler instead.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@gpetrou gpetrou added the Feature label Mar 8, 2024
@flobernd
Copy link
Member

flobernd commented Mar 8, 2024

Updating the action to a better supported one is probably a good idea. However, what I can tell from a quick check, the root of the error seems to be a permission problem.

I think the action should be triggered by pull_request_target instead of pull_request and additionally needs:

permissions:
  contents: read
  pull-requests: write

The whole CI, actions, automations in this repository should be modernized at some point... For now, the client itself has highest priority, but I've put an item on my backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants