#2305 Remove polyfill packages #2308
Conversation
thompson-tomo
force-pushed
the
chore/#2305_RemovePolyfill
branch
from
b360d7d
to
b117e82
Compare
thompson-tomo
force-pushed
the
chore/#2305_RemovePolyfill
branch
from
b117e82
to
efb81fd
Compare
thompson-tomo
force-pushed
the
chore/#2305_RemovePolyfill
branch
2 times, most recently
from
e7dc387
to
d54dbfb
Compare
|
@v1v is this something you could review? |
thompson-tomo
force-pushed
the
chore/#2305_RemovePolyfill
branch
from
d54dbfb
to
e59b174
Compare
I'm afraid I'm not part of this project and lack of some .Net skills to help with the review. Let me ping @elastic/dotnet |
|
Thanks @v1v |
|
Hey @thompson-tomo we will get to this PR as soon as our current priorities allow! The PR is much appreciated (like the others on our other repositories). The build of this repos is a bit more complicated so we have to carve out a little more time to review this than we did on the other PR's. I'm off on PTO now so can't dive in yet :) |
|
Ok thanks for the update @Mpdreamz e joy the time off. |
There was a problem hiding this comment.
This LGTM!
Would love to clean this up a tad since we built this in a few different ways now.
A regular nuget build which results in no dependencies (as verified on https://nuget.info/).
And a self contained build for the startup hooks zip files which will still include the dependency which I think is fine for now.
Many thanks for taking this on @thompson-tomo ❤️
|
No problem at all @Mpdreamz glad I could help. 🙂 |
|
run docs-build |
The polyfil packages listed below will only be included in frameworks less than net 6 to reduce dependency graph
Closes: #2305