Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing colors cannot be suppressed #65

Open
ciis0 opened this issue Nov 30, 2022 · 1 comment
Open

tracing colors cannot be suppressed #65

ciis0 opened this issue Nov 30, 2022 · 1 comment

Comments

@ciis0
Copy link

ciis0 commented Nov 30, 2022

I am running bore to expose local ports to a remote Windows server and it works quite well, thank you!

The only annoyance I have noticed that log/tracing colors do not seem to be able to be turned off, which make the log files look funny when for example wrapping bore in WinSW (for running as a Windows service).

image

I tried NO_COLOR, that only affects the help colors; but that does not affect tracing: tokio-rs/tracing#2388.

Opening this issue to make you aware of that so it could be fixed when there is a fix in tokio tracing. :)

@ekzhang
Copy link
Owner

ekzhang commented Nov 30, 2022

I'm glad it's working well for you! That's awesome :)

I didn't realize that tracing-subscriber had no way to turn off colors via environment variable. Sounds like the upstream issue has some activity so I think we could wait and see, and I'm happy to publish a release of bore when tracing is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants