Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux assumes presence of gedit #20

Closed
hlascelles opened this issue Sep 13, 2019 · 3 comments
Closed

Linux assumes presence of gedit #20

hlascelles opened this issue Sep 13, 2019 · 3 comments

Comments

@hlascelles
Copy link

Simple one: during init on Mint Linux, I see:

command not found: gedit

This is because gedit is assumed. Mint uses xed. Can we make this an ENV, or maybe it could try for both?

@eko
Copy link
Owner

eko commented Sep 14, 2019

Hi @hlascelles,

Thank you for your feedback and reporting this issue.

I just fixed that: I've added the xed editor to an editor list so if you don't have gedit installed, it will fallback on xed.

Also, I've added an environment variable to force the editor value so you can also use MONDAY_EDITOR=xed(or another value) if you want.

I hope it will satisfy your needs. Closing this issue now, feel free to re-open if you have other issues concerning this subject.

This will be shipped into v1.0.7 version in the coming days.

For more information, see PR https://github.com/eko/monday/pull/22/files

Thank you

@eko eko closed this as completed Sep 14, 2019
@hlascelles
Copy link
Author

Great, thanks, looks good, I will give the next version a go when it's out. Thank you for jumping on it.

@hlascelles
Copy link
Author

Works great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants