Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): replace mockery by gomock and fix race conditions #17

Merged
merged 1 commit into from Dec 8, 2019

Conversation

eko
Copy link
Owner

@eko eko commented Dec 7, 2019

No description provided.

@codecov
Copy link

codecov bot commented Dec 7, 2019

Codecov Report

Merging #17 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   94.77%   94.96%   +0.19%     
==========================================
  Files          13       13              
  Lines         459      477      +18     
==========================================
+ Hits          435      453      +18     
  Misses         13       13              
  Partials       11       11
Impacted Files Coverage Δ
store/redis.go 71.42% <ø> (ø) ⬆️
cache/metric.go 100% <100%> (ø) ⬆️
metrics/prometheus.go 100% <100%> (ø) ⬆️
cache/chain.go 100% <100%> (ø) ⬆️
cache/loadable.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b6c810...3b46630. Read the comment docs.

@eko
Copy link
Owner Author

eko commented Dec 8, 2019

This PR fixes #15

@eko eko merged commit 99c1da9 into master Dec 8, 2019
@eko eko deleted the replace-mockery-with-gomock branch December 8, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant