improvements for uploads #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…00003..failed (13: Permission denied)
eko
approved these changes
Oct 27, 2018
|
Hi @gritt, I never encounter a use case that needs these parameters but it looks ok to be merged in the project: future users should not have issues about this configuration. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having some issues getting uploads working on symfony4, i've ended up discovering an issue that might affect certain versions of nginx over alpine.
dockerfile/nginx#4
https://wincent.com/wiki/Fixing_nginx_client_body_temp_permission_denied_errors
Adding these fixes for nginx, (set a writable tmp dir config), and also installing php7-fileinfo (symfony requirement) fixed completely my issues regarding file uploads in symfony4.
What do you guys think?