Added xdebug extension #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about giving some feedback or anything else? @eko |
eko
reviewed
Apr 10, 2018
README.md
Outdated
| @@ -64,6 +64,11 @@ You can access Nginx and Symfony application logs in the following directories o | |||
|
|
|||
| You can also use Kibana to visualize Nginx & Symfony logs by visiting `http://symfony.localhost:81`. | |||
|
|
|||
| # Use xdebug! | |||
|
|
|||
| To use xdebug change the line `"docker.host:127.0.0.1"` in docker-compose.yml and replace 127.0.0.1 with your machines ip addres. | |||
There was a problem hiding this comment.
Great but can you fix typos here please:
your machines ip addres -> your machine ip address
README.md
Outdated
| # Use xdebug! | ||
|
|
||
| To use xdebug change the line `"docker.host:127.0.0.1"` in docker-compose.yml and replace 127.0.0.1 with your machines ip addres. | ||
| If your IDEs default port is not set to 5902 you should do that, too. |
|
Hi, could you merge this ? 👍 |
|
I fixed the typos so it can be merged. |
|
Thank you @Padrio! I will just give it a try tomorrow and I will merge then, but it seems to be ok :) |
eko
approved these changes
Jul 6, 2018
|
It's merged. Thank you @Padrio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.