Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update For Symfony 4 ?? #64

Closed
wants to merge 6 commits into from
Closed

Update For Symfony 4 ?? #64

wants to merge 6 commits into from

Conversation

Muspi
Copy link

@Muspi Muspi commented Apr 25, 2018

Q A
Branch? "master"
Bug fix? yes/no
New feature? yes/no
BC breaks? yes/no
Deprecations? yes/no
Tests pass? yes/no
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT
Doc PR reference to the documentation PR, if any

@@ -1,19 +1,13 @@
{
"name": "eko/feedbundle",
"name": "muspi/feedbundle",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep original bundle name here please? Also restore the authors section. Thank you.

@Shine-neko
Copy link

@Muspi @eko ?

@eko
Copy link
Owner

eko commented Sep 14, 2018

Hello @Muspi @Shine-neko,

Closing this PR as I've updated the work of @Muspi in the following PR: #66

Thank you for your contributions.

@eko eko closed this Sep 14, 2018
@eko
Copy link
Owner

eko commented Sep 14, 2018

I just pushed tag 1.2.9 containing upgrade for Symfony4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants