New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added arguments to functions #136
Conversation
Added functionality to get custom headers, footers and sidebars.
Twig/Extension/ThemeExtension.php
Outdated
@@ -45,9 +45,9 @@ public function getFunctions() | |||
/** | |||
* Displays Wordpress theme header (and administration menu bar if available). | |||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, could you also update PHPdoc on methods your updated please? Just to add the new argument:
* @param string|null $name
Just added :) |
Twig/Extension/ThemeExtension.php
Outdated
} | ||
|
||
/** | ||
* Displays a Wordpress theme template part. | ||
* | ||
* @param string $name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be $slug here please ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Sorry) This was a 2 a.m. when I write this)
Thank you @dmtrpro :) |
Added functionality to get custom headers, footers and sidebars.