Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define 'ekino_wordpress.model_manager_name' automatically #132

Merged
merged 1 commit into from Mar 8, 2017
Merged

Define 'ekino_wordpress.model_manager_name' automatically #132

merged 1 commit into from Mar 8, 2017

Conversation

jdecool
Copy link
Contributor

@jdecool jdecool commented Mar 8, 2017

I you want to use a custom entity manager by setting the entity_manager in your app configuration, it doesn't work.

I find it is because the ekino_wordpress.model_manager_name parameter which is used in the RegisterMappingsPass is not defined.

In case the use have change the default entity manager, doesn't this parameter should be automatically register ?
Even if it is automatically setup, developers can override it.

@jdecool jdecool changed the title Define 'ekino_wordpress.model_manager_name' automatically if custom entity manager is defined Define 'ekino_wordpress.model_manager_name' automatically Mar 8, 2017
@eko eko merged commit 4bd4d4f into ekino:master Mar 8, 2017
@eko
Copy link
Collaborator

eko commented Mar 8, 2017

Indeed, thank you for this fix @jdecool!

@jdecool
Copy link
Contributor Author

jdecool commented Mar 29, 2017

Thanks for the merge @eko

Could you tag a new release with this fix ?

@eko
Copy link
Collaborator

eko commented Mar 29, 2017

Hi @jdecool,

For sure, I just created tag 1.2.1 containing your commit: 1.2.0...1.2.1

Thank you

@jdecool
Copy link
Contributor Author

jdecool commented Mar 30, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants