window.dispatchEvent(new Event('resize')) causing infinite loop

[TrySpace]

One of my masonry's parent components is listening to the resize event, causing the componentDidUpdate of the mixin to fire, causing the resize listener to fire again..

I'm fixing this now by doing:

shouldComponentUpdate: function(nextProps, nextState){
    return nextProps.window.width !== this.props.window.width
},

in the masonry element.

But I think this could cause issues for other users as well.

I'm not sure how to prevent this in the mixin, other than triggering update on masonry manually...

[eiriklv]

This has been fixed now :-)

[eiriklv]

No longer triggering resize event

[Chrazy]

The changes actually trigger a weird behaviour for me. The height or the wrapper isn't calculated the same way, it gets doubled for some reason. Trying to see what could be causing it but it could be good to know that the change had an unforeseen outcome.

[Chrazy]

Re-adding the line "this.masonry.reloadItems();" in componentWillReceiveProps seems to fix the problems I'm seeing.

[eiriklv]

@Chrazy Will look into it straight away :-)

[Chrazy]

Hope you manage to reproduce my findings. Quick response time!

[eiriklv]

Pushed new version (0.5.3 on npm) with the proposed fix. please test and report back if you have time :-)

[Chrazy]

Seems to do the trick for me at least :)

[eiriklv]

@Chrazy great :-) nothing else seems to break, and the addition makes sense.

[Chrazy]

I actually ran in to the same problem once again in some cases. I haven't had time to set up small case to reproduce it but reverting back to 0.4 fixes the problem for now. Should create a new issue when someone else runs into it as it's not really part of this one.

[eiriklv]

It still happens with 0.5.3? Hmm.. what actually happens?

[Chrazy]

The wrapper containing the blocks gets it's height doubled, so all the blocks gets pushed down.

[Chrazy]

It seems to be something that happens when the number of blocks are odd (I know, odd right...). I'll dig a bit more to see which commit that caused it.

[Chrazy]

Seems like 0.5 was the commit that caused the double height actually.

[eiriklv]

@Chrazy It would be great with a demo case that causes this, so I can test. I can't seem to reproduce it
:-)