Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActF/TCF/TSF should include digest of persistent log contents #358

Open
magnusbaeck opened this issue Jul 3, 2023 · 2 comments
Open

ActF/TCF/TSF should include digest of persistent log contents #358

magnusbaeck opened this issue Jul 3, 2023 · 2 comments
Labels
protocol All protocol changes

Comments

@magnusbaeck
Copy link
Member

magnusbaeck commented Jul 3, 2023

Description

Just like ArtC can include the digest of the artifact files to enable detection of tampering (via data.fileInformation.integrityProtection), it should also be possible to include the digest of the persistent logs announced in ActF, TCF, and TSF (e.g. data.persistentLogs.integrityProtection).

If implemented, we should probably define a new struct type (like EiffelMetaProperty and EiffelEventLink) for the integrityProtection members to reduce duplication and enable nicer SDKs.

Motivation

Activity logs could contain audit information or similar where it's vital that tampering (or corruption) is detected. Right now the only way of using Eiffel to convey that information is to expose the logs as artifacts, and while that's not completely unreasonable, we already provide a standard mechanism for exposing activity logs and it would be a pity to not support this use case.

Exemplification

N/A

Benefits

Allow detection of tampering or corruption of activity logs (if that information is provided by the publisher).

Possible Drawbacks

None.

@magnusbaeck magnusbaeck added the protocol All protocol changes label Jul 3, 2023
@m-linner-ericsson
Copy link
Member

Sounds like an reasonable idea. We do have the same type of logs in TCF and TSF, should we add it for those events also?

@magnusbaeck
Copy link
Member Author

Ah, right. Forgot about those. Yes, definitely. And that makes the case for a new struct type even stronger.

@magnusbaeck magnusbaeck changed the title ActF should include digest of persistent log contents ActF/TCF/TSF should include digest of persistent log contents Jul 5, 2023
@magnusbaeck magnusbaeck added this to the Edition Santiago milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol All protocol changes
Projects
Status: Todo
Development

No branches or pull requests

2 participants