Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules are not tested enough #442

Open
ghost opened this issue Feb 19, 2020 · 0 comments
Open

Rules are not tested enough #442

ghost opened this issue Feb 19, 2020 · 0 comments
Assignees
Labels
code improvements Improvements to make the code base more readable and manageable.

Comments

@ghost
Copy link

ghost commented Feb 19, 2020

Description

Todays' tests are hard coded to use older versions of rule sets that has since been updated. This has caused a lot of bugs to appear (see issues #439 and #441) and makes me wonder why the 'sharp' rules are not being tested rigorously.

The previously mentioned issues have been there for quite some time without the tests failing, because the tests are using their own versions of rule sets....

Motivation

We should properly test the rule sets we actually deliver together with Eiffel Intelligence. We need to know they are working as expected - and if they don't, our tests should discover that something is broken.

Exemplification

As an example, src/test/.../FlowTestTestExecution uses src/test/resources/TestExecutionObjectRules.json instead of src/main/resources/rules/TestExecutionObjectRules-Eiffel-Agen-Version.json

I'm sure there are other places in which we could replace duplicated test resource files with using the actual deliverables instead...

Benefits

Actually testing the rules we have created (and deliver together with Eiffel Intelligence source code).

Possible Drawbacks

Some tests might expect a certain strcture of the aggregation (which is defined by the rules) so it might not be viable to replace which rules to use in every test ...

@e-pettersson-ericsson e-pettersson-ericsson added the code improvements Improvements to make the code base more readable and manageable. label Feb 20, 2020
@saif-ericsson saif-ericsson self-assigned this Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code improvements Improvements to make the code base more readable and manageable.
Projects
None yet
Development

No branches or pull requests

2 participants