Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and refactor SubscriptionHandler #423

Open
e-pettersson-ericsson opened this issue Jan 15, 2020 · 0 comments
Open

Rename and refactor SubscriptionHandler #423

e-pettersson-ericsson opened this issue Jan 15, 2020 · 0 comments
Labels
code improvements Improvements to make the code base more readable and manageable.

Comments

@e-pettersson-ericsson
Copy link
Member

Description

SubscriptionHandler does a lot of different things, and the name is not very descriptive. Refactor the class into separate smaller ones, which each has one single responsibility. Then it's hopefully easier to name these.

Motivation

It is good to have separation of concern.
Increases robustness by avoiding a very long complicated chain of actions (which are hard to test).

Exemplification

Benefits

Easier to follow the code. Separating concerns.

Possible Drawbacks
@e-pettersson-ericsson e-pettersson-ericsson added the code improvements Improvements to make the code base more readable and manageable. label Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code improvements Improvements to make the code base more readable and manageable.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@e-pettersson-ericsson