Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get web template from definitions api according to specification #990

Open
6 tasks
abebehailu opened this issue Oct 26, 2022 · 1 comment
Open
6 tasks
Labels
documentation Improvements or additions to the documentation enhancement New feature or request

Comments

@abebehailu
Copy link

Configuration information

EHRbase version: 0.21.1
openEHR_SDK version: 1.19.0
Archie version: 2.0.1
PostgreSQL version: PostgreSQL 13.4
Java Runtime version: Oracle Corporation 11.0.15
Operating System version: Linux amd64 4.18.0

Steps to reproduce

According to the OpenEHR specification of the definitions api; a client should be able to send request with the accept header "application/openehr.wt+json" to get a template in web template format. The request should be done towards this endpoint: "/definition/template/adl1.4/{template_id}".

Actual result

Status code 406 Not Acceptable.

Expected result (Acceptance Criteria)

Status code 200 with template in web template format.

According to your documentation there is another endpoint that works "/ehrbase/rest/ecis/v1/template/{templateId}". It would be great if you could consolidate this with the specification. There is a discussion on the topic on OpenEHR discourse.

Definition of Done

  • The defect is checked by an unit or an integration test (Robot)
  • Merge Request approved
  • Unit tests passed
  • Build without errors
  • Release notes prepared
  • No additional runtime warnings
@abebehailu abebehailu added the bug Something isn't working label Oct 26, 2022
@vladislavploaia
Copy link
Contributor

Hello @abebehailu,
Thanks for pointing on this issue.
This type of Accept header value was added in a newer version of specifications, therefore, it is still not implemented even in EHRBase version v.0.22.0.
Implementation is planned after we have the confirmation about new version of specifications.
In terms of timings, don't have enough clarity on that side.
In any case, will let you know,

CC: @stefanspiska

@vladislavploaia vladislavploaia added enhancement New feature or request documentation Improvements or additions to the documentation and removed bug Something isn't working labels Nov 10, 2022
@abebehailu abebehailu removed their assignment Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to the documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants