Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Silk] SVG logo that represents this WB #10

Closed
luzpaz opened this issue Oct 2, 2018 · 29 comments · Fixed by FreeCAD/FreeCAD#3128
Closed

[Silk] SVG logo that represents this WB #10

luzpaz opened this issue Oct 2, 2018 · 29 comments · Fixed by FreeCAD/FreeCAD#3128

Comments

@luzpaz
Copy link
Contributor

luzpaz commented Oct 2, 2018

ref: https://www.freecadweb.org/wiki/Template:DevWorkbenches

@luzpaz
Copy link
Contributor Author

luzpaz commented Jun 14, 2019

@luzpaz luzpaz changed the title What's the logo that represents this WB ? [Silk] SVG logo that represents this WB Jun 14, 2019
@luzpaz
Copy link
Contributor Author

luzpaz commented Jun 17, 2019

@edwardvmills ping

@edwardvmills
Copy link
Owner

i had one in progress, but it was too detailed. i haven't worked on it in a long time.

unfortunately, i have no idea when i'll have time to work on this again...i hope soon.

@luzpaz
Copy link
Contributor Author

luzpaz commented Jun 20, 2019

can we post a request to the UI/UX forum to see if someone will create one in the meantime ?

@edwardvmills
Copy link
Owner

honestly i'd rather not at this time. it feels kind of personal. as far as i know, no one has reported using the workbench outside of a few people testing it very early on. now if lots of people were using it, and the lack of icon clarity was causing productivity issues, i suppose i wouldn't stand in the way.

On my computer, the crappy existing icon loads as it is. does it not show up on other people's machines?

like i said, it exists, but it doesn't do a very good job as an icon

`class Silk (Workbench):

def __init__(self):
	self.__class__.Icon = FreeCAD.getUserAppDataDir()+"Mod" + "/Silk/Resources/Icons/Silk.svg"
	self.__class__.MenuText = "Silk"
	self.__class__.ToolTip = "NURBS Surface modeling tools focused on low degree and seam continuity "`

@edwardvmills
Copy link
Owner

@edwardvmills
Copy link
Owner

it was a bummer when i saw it was an unreadable mess at final size, because i had fun drawing it with the workbench itself. as shown above, a lot intricacies of the design have already been removed, and it still is unreadable as the icon in the workbench drop down

@edwardvmills
Copy link
Owner

i'm trying to read up on
https://forum.freecadweb.org/viewtopic.php?f=9&t=36556

so i can see what i ought to take of right now.

@luzpaz
Copy link
Contributor Author

luzpaz commented Jun 24, 2019

no pressure. :)

@luzpaz
Copy link
Contributor Author

luzpaz commented Aug 8, 2019

@edwardvmills
How about using the shape in this?

example of current capability

@edwardvmills
Copy link
Owner

I guess it depends what size you want for the final icon. My previous reference size was the icons in the workbench dropdown menu, and those are tiny.

when you initially posted this thread, where did you envision anyone seeing this icon?

@luzpaz
Copy link
Contributor Author

luzpaz commented Aug 9, 2019

In the addon manager workbench/addon menu.. right now there is no icon next to your workbench in it.

@luzpaz
Copy link
Contributor Author

luzpaz commented Aug 9, 2019

image

@luzpaz
Copy link
Contributor Author

luzpaz commented Aug 9, 2019

Checkout FreeCAD/FreeCAD#2403

@luzpaz
Copy link
Contributor Author

luzpaz commented Aug 9, 2019

I guess it depends what size you want for the final icon. My previous reference size was the icons in the workbench dropdown menu, and those are tiny.

https://github.com/FreeCAD/FreeCAD/tree/master/src/Mod/AddonManager/Resources/icons

@luzpaz
Copy link
Contributor Author

luzpaz commented Sep 11, 2019

you can scale an svg up or down no problem, so size isn't relevant.

@edwardvmills
Copy link
Owner

i know vector graphics scale, that's not what i'm concerned about. a functional icon should be discernable at the size it will normally be seen. if this icon will be seen in in the WB drop down, and the addon manager left side logos, it needs to communicate something, when seen at that size using default application icon size. It just happens to be that in these two instances the icons are displayed quite small by FreeCAD, compared to toolbar icons, for example.

This is just a design challenge. I have a new icon idea, but it's not ready yet.

@edwardvmills
Copy link
Owner

from your linked issue above:
"Will help users understand what the addon does when they browse through the list of addons"
in the case of this workbench, it's a bit of a challenge to communicate something useful....but i have some ideas...it's ready when it's ready :)

@luzpaz
Copy link
Contributor Author

luzpaz commented Sep 16, 2019

There are several addons that are not discernable by name or logo, so I wouldn't worry about that. It's more about how you structure your README.md page than anything, IMHO. That's what the user is going to go with.

@luzpaz
Copy link
Contributor Author

luzpaz commented Oct 15, 2019

Any updates ?

@luzpaz
Copy link
Contributor Author

luzpaz commented Oct 28, 2019

@edwardvmills bump

@luzpaz
Copy link
Contributor Author

luzpaz commented Nov 29, 2019

@edwardvmills any thoughts on this?

@luzpaz
Copy link
Contributor Author

luzpaz commented Feb 29, 2020

We'd love to have logo in the Addon Manager and several wiki pages + a dedicated wiki page for this Addon as well ...
so pretty please can you decide on an icon 😅

@edwardvmills
Copy link
Owner

ok, i just decided to bite the bullet and remove the text from an existing icon....but i had to download inkscape and i have very slow internet....soon!

thank you for your tenacity.

@edwardvmills
Copy link
Owner

@luzpaz
Copy link
Contributor Author

luzpaz commented Mar 4, 2020

Just created https://wiki.freecadweb.org/Silk_Workbench
Congrats 😄

luzpaz added a commit to luzpaz/FreeCAD that referenced this issue Mar 4, 2020
@edwardvmills
Copy link
Owner

Thanks luzpaz!

@luzpaz
Copy link
Contributor Author

luzpaz commented Mar 5, 2020

Note: I was asked to save the SVG as a Plain SVG, see FreeCAD/FreeCAD#3128 (comment)

@edwardvmills
Copy link
Owner

ok, found the relevant option in inkscape. pushed. should be good now

yorikvanhavre pushed a commit to FreeCAD/FreeCAD that referenced this issue Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants