Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrap form control in flush sync #496

Merged
merged 2 commits into from Mar 7, 2024
Merged

fix: wrap form control in flush sync #496

merged 2 commits into from Mar 7, 2024

Conversation

edmundhung
Copy link
Owner

Fix #400.

This ensures all form intent applies to the latest form data in case multiple intents are dispatched in one single callback. Note: This only works with client validation in place in which an update can be triggered synchronously.

Copy link

cloudflare-pages bot commented Mar 6, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e5454ec
Status: ✅  Deploy successful!
Preview URL: https://a40246b4.conform.pages.dev
Branch Preview URL: https://multiple-intents.conform.pages.dev

View logs

@edmundhung edmundhung force-pushed the multiple-intents branch 2 times, most recently from a32527d to b4ed819 Compare March 6, 2024 22:41
@edmundhung edmundhung merged commit f0d899f into main Mar 7, 2024
3 checks passed
@edmundhung edmundhung deleted the multiple-intents branch March 7, 2024 19:38
edmundhung added a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The form value is out of sync if we are dispatching multiple intents in a row
1 participant