The form value is out of sync if we are dispatching multiple intents in a row

[edmundhung]

Describe the bug and the expected behavior

Originally reported by @Pouet-- on #331 (reply in thread)

Conform version

v1.0.0-rc.1

Steps to Reproduce the Bug or Issue

I reproduced the "bug" in a codesandbox, you can try to drag the first level items and drop them into the sub-level node : the number of children updates accordingly but the list is not correctly displayed. However, if you add an item in the sub-list after that, it retrieves the lost values.

What browsers are you seeing the problem on?

No response

Screenshots or Videos

No response

Additional context

No response

[edmundhung]

@Pouet-- Let's move the discussion here. The issue you see will be resolved if you identify the child type with initialValue instead of value on these 2 lines:

childFieldset.type.initialValue === TreeNodeType.LOGIC
childFieldset.type.initialValue === TreeNodeType.FILTER

The issue is that Conform's value get out of sync and mess up if you dispatch more than one intents in one callback. Definitely something I need to look into further. 😅

Thanks again for preparing the repo!

[Pouet--]

I changed parts of my code since v1 is released to use value on my fields, did not expect the problem to be related to this.
Thank you very much for taking the time to look into this problem !

[Pouet--]

For information, I hacked this problem with the following :

flushSync(() => {
  form.insert({ name: ..., defaultValue: ... });
});
flushSync(() => {
  form.remove({ name: ..., index: ... });
});

It waits for a re-render before launching the second operation, so the values are correctly filled, but this triggers 2 re-renders

[edmundhung]

In v1.0.3, Conform has all form intents wrapped in a flush sync already so there is no need to wrap it yourself.

[QzCurious]

Hi, @edmundhung. I'd argue conform wrap form intent (maybe I should say wrap programatic for intent) is not a good decision. Maybe state flushSync() way on doc would be better.

One significant drawback wrapping every form intent with flushSync() I had is that I hook up field values to render / not-render something. If I'd want to show three things on screen, it would show one by one instead of three at the same time.