Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAF tests are not HTTP2 compatible - does case-sensitive header comparisons #757

Open
bnevis-i opened this issue Jan 10, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@bnevis-i
Copy link
Contributor

馃悶 Bug Report

Affected Services [REQUIRED]

Mostly all TAF HTTP tests

Is this a regression?

No

Description and Minimal Reproduction [REQUIRED]

According to https://blog.yaakov.online/http-2-header-casing/
the canonical headers for HTTP2 requests require HTTP headers to be lowercased.
If return headers are lowercased, TAF tests will fail; most will fail checking 'Content-Type'

This behavior violates internet standards. Headers should be case-insensitive.

馃敟 Exception or Error


''None' == 'applicaiton/json'' should be true

馃實 Your Environment

Deployment Environment: docker

EdgeX Version [REQUIRED]: minnesota (tip)

Anything else relevant? proxying requests in HTTP2 mode via haproxy

@bnevis-i bnevis-i added the bug Something isn't working label Jan 10, 2023
@cherrycl
Copy link
Contributor

@bnevis-i For clarification, what is Content-Type return when using HTTP2? Is it None?

@bnevis-i
Copy link
Contributor Author

content-type: application/json

but it works for

Content-Type: application/json

@cherrycl
Copy link
Contributor

@bnevis-i Thanks. I will investigate it later.

@cloudxxx8
Copy link
Member

@cherrycl let's make all the http header check become case-insensitive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Release Backlog
Development

No branches or pull requests

3 participants