Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjacent variants crash svaha2 #8

Open
edawson opened this issue Oct 13, 2019 · 0 comments
Open

Adjacent variants crash svaha2 #8

edawson opened this issue Oct 13, 2019 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@edawson
Copy link
Owner

edawson commented Oct 13, 2019

I have repeatedly run into this issue so it's high time I write it down. Variants in a vcf with adjacent positions will cause a segfault, probably because of some sloppy pointer invalidation I coded in mid-thesis.

The right way to fix this is to make a map from genomic position -> a list of alleles/nodes, rather than a single entity. This increases the code complexity but would be a useful improvement.

@edawson edawson added bug Something isn't working enhancement New feature or request labels Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant