Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context Buttons for Selection and Hover of EditParts #261

Open
azoitl opened this issue Aug 31, 2023 · 5 comments
Open

Context Buttons for Selection and Hover of EditParts #261

azoitl opened this issue Aug 31, 2023 · 5 comments

Comments

@azoitl
Copy link
Contributor

azoitl commented Aug 31, 2023

@sebHollersbacher and I are currently working on a prototype for a context button infrastructure for the graphical editors of 4diac IDE. This is inspired by the the ContextButtons in Graphiti but we hope to get a bit simpler API.

ContextButton-Graphiti ContextButton-Graphiti

Based on the Eclipse Platform's Command Infrastructure our first prototype can show buttons on all 4 sides of a Figure. When the user moves mouse to 1 side, it hides all the other sides.

ContextButton-left ContextButton-sides ContextButton top

In our work we tried to keep the whole infrastructure as generic as possible. Therefore we think we could upstream it to GEF Classic.
Our approach would be to integrate it in the NonResizableEditPolicy in such a way that it will not affect any existing code. But users who would like to have it would just need to implement a dedicated response in the getAdapter method.

The first version of our prototype can be found in the 4diac IDE Gerrit.

What do you think is this something we should move to GEF Classic or keep it in 4diac IDE.

\cc @pcdavid @Phillipus @ptziegler

@ddscharfe
Copy link

👍
It would be really nice to have this feature in gef.

@Phillipus
Copy link
Contributor

Sorry for not responding earlier. I agree that this would be a nice feature, as long as it is optional and doesn't affect existing API. But then I know you know that anyway ;-)

@sebHollersbacher
Copy link
Contributor

The current status can be seen in the video.
Additionally, the buttons have a tooltip, which can not be seen in the video for some reason, to better indicate which command a button executes.

Demo_ContextButton.mp4

Copy link

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale label Dec 26, 2023
@azoitl azoitl removed the stale label Dec 28, 2023
Copy link

This issue is stale because it has been open for 90 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants