Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomEditorProvider Cannot Saved file through function "document.save()" #9230

Open
SunnyFitz opened this issue Mar 22, 2021 · 4 comments · May be fixed by #13684
Open

CustomEditorProvider Cannot Saved file through function "document.save()" #9230

SunnyFitz opened this issue Mar 22, 2021 · 4 comments · May be fixed by #13684
Labels
custom-editor issues related to custom-editor functionality

Comments

@SunnyFitz
Copy link

Bug Description:

document.save() in CustomEditorProvider cannot working properly

Steps to Reproduce:

  1. Create a new file worked on CustomEditorProvider
  2. make a change on editor area
  3. use Ctrl + S to save file (I used acquireTheiaApi , Created a socket to send message to call document.save on my CustomEditorProvider ), which has called save function but not success
  4. click other area （resource explorer or editor title bar ） or open file in code editor and custom editor， than use Ctrl+S to call document.save and it worked

image
image

  • Operating System: Linuxmint
  • Theia Version: 1.12.0-next.9f13354e
@vince-fugnitto vince-fugnitto added the custom-editor issues related to custom-editor functionality label Mar 22, 2021
@vince-fugnitto
Copy link
Member

cc @danarad05 perhaps you can help, or understand why it may not work this way.

@SunnyFitz
Copy link
Author

i canceled keyevent in js which run in webview . Then Ctrl + S can work properly.

but customEditor cannot active theia.workspace.onDidChangeActiveTextEditor, so i cannot get customEditor focus changed event.
Is there hava others way to get focused status of customEditor ?

@danarad05
Copy link
Contributor

@SunnyFitz
Thanks for letting us know of issue. Could you please add your example project and a short screen shots video of scenario so I could reproduce issue.
Thanks

@amos42
Copy link
Contributor

amos42 commented Aug 3, 2021

This problem does not occur in v1.13.0.
This problem has occurred since v1.14.0, and the problem persists in v1.16.0.

@msujew msujew mentioned this issue Aug 25, 2023
Merged
2 tasks
This was referenced May 5, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
custom-editor issues related to custom-editor functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix programmatic save for custom text editors eclipse-theia/theia
4 participants
@SunnyFitz @vince-fugnitto @amos42 @danarad05