Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overflow behavior for sidepanels not working correctly #13482

Open
tortmayr opened this issue Mar 12, 2024 · 3 comments · May be fixed by #13483
Open

Overflow behavior for sidepanels not working correctly #13482

tortmayr opened this issue Mar 12, 2024 · 3 comments · May be fixed by #13483
Assignees
@tortmayr

Comments

@tortmayr
Copy link
Contributor

Bug Description:

For certain corner cases the tab overflow behavior for sidebars introduced with #12593 is not working correctly:

  • The overflow behavior does not work as expected if only two tabs are in the tabbar (and none are hidden via '...' menu)
  • The last visible element never gets added to the ... menu even if there is not enough space to show it.
    Overflow computation does not consider potential custom styling. Eg. if additional margin between icons are added in an adopter project the overflow calculation will be off.
@tortmayr tortmayr self-assigned this Mar 12, 2024
tortmayr added a commit to eclipsesource/theia that referenced this issue Mar 12, 2024
@tortmayr
Fix overflow behavior of sidebars
2b3bc77 
- Ensure that last visible element also gets added to `...` overflow menu if there is not enough space
- Remove special behavior for only one overflowing element
  -  This behavior would always add a second element to the `overflow` menu if only one element is currently overflowing. This did not work for the case where only two tabs where open in the first place. In addition, it unnecessarily hide a tab in some cases even if there was enough space to render it.
- Also consider potential tab margins in overflow computation

Fixes eclipse-theia#13482

Contributed on behalf of STMicroelectronics
@tortmayr tortmayr linked a pull request Mar 12, 2024 that will close this issue
Open
1 task
@tsmaeder
Copy link
Contributor

I don't really understand what the problem here is. For me, this seems to work just fine: any view that is hidden is added to the ...-menu. Steps, please?

@tsmaeder
Copy link
Contributor

@tortmayr

@tsmaeder
Copy link
Contributor

@tortmayr ping.

tortmayr added a commit to eclipsesource/theia that referenced this issue Mar 26, 2024
@tortmayr
Fix overflow behavior of sidebars
c0cc040 
- Ensure that last visible element also gets added to `...` overflow menu if there is not enough space
- Remove special behavior for only one overflowing element
  -  This behavior would always add a second element to the `overflow` menu if only one element is currently overflowing. This did not work for the case where only two tabs where open in the first place. In addition, it unnecessarily hide a tab in some cases even if there was enough space to render it.
- Also consider potential tab margins in overflow computation

Fixes eclipse-theia#13482

Contributed on behalf of STMicroelectronics
tortmayr added a commit to eclipsesource/theia that referenced this issue May 10, 2024
@tortmayr
Fix overflow behavior of sidebars
2df74d8 
- Ensure that last visible element also gets added to `...` overflow menu if there is not enough space
- Remove special behavior for only one overflowing element
  -  This behavior would always add a second element to the `overflow` menu if only one element is currently overflowing. This did not work for the case where only two tabs where open in the first place. In addition, it unnecessarily hide a tab in some cases even if there was enough space to render it.
- Also consider potential tab margins in overflow computation

Fixes eclipse-theia#13482

Contributed on behalf of STMicroelectronics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tortmayr tortmayr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix overflow behavior of sidebars eclipsesource/theia
2 participants
@tortmayr @tsmaeder