Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode: Missing partial icon and color API support for ExtensionTerminalOptions and TerminalOptions #12074

Open
Tracked by #12010
rschnekenbu opened this issue Jan 16, 2023 · 2 comments · May be fixed by #13413
Open
Tracked by #12010

vscode: Missing partial icon and color API support for ExtensionTerminalOptions and TerminalOptions #12074

rschnekenbu opened this issue Jan 16, 2023 · 2 comments · May be fixed by #13413
Labels
terminal issues related to the terminal vscode issues related to VSCode compatibility

Comments

@rschnekenbu
Copy link
Contributor

With #11504, the added API was partially stub. Currently, only a ThemeIcon is supported, while the vscode API provides also support for URI and {dark: URI, liught: URI}. Also the color icon support has been stubbed, as the current implementation of the title widget as terminal title does not let an easy customization of the icon color.
@vince-fugnitto vince-fugnitto added terminal issues related to the terminal vscode issues related to VSCode compatibility labels Jan 16, 2023
@rschnekenbu rschnekenbu mentioned this issue Jan 16, 2023
Closed
2 tasks
@planger planger mentioned this issue Jan 16, 2023
Open
5 tasks
@msujew msujew mentioned this issue Jun 22, 2023
Closed
@kittaakos
Copy link
Contributor

From #12645 (comment):

ExtensionTerminalOptions#iconPath is currently unsupported by Theia.

Create a terminal with vscode.window.createTerminal(options: ExtensionTerminalOptions): Terminal, set the iconPath to heart.

VS Code:

Screen Shot 2023-06-22 at 10 50 13 Theia: Screen Shot 2023-06-22 at 10 51 34

Feature Description:

ExtensionTerminalOptions#iconPath works as in VS Code.

@tsmaeder tsmaeder mentioned this issue Jul 11, 2023
Closed
@FernandoAscencio FernandoAscencio mentioned this issue Aug 24, 2023
Closed
1 task
@dhuebner
Copy link
Contributor

I will take the PR over to apply the review suggestions.

@dhuebner dhuebner linked a pull request Feb 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
terminal issues related to the terminal vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
4 participants
@dhuebner @kittaakos @rschnekenbu @vince-fugnitto