Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

registerUriHandler is not implemented #13169

Open
mathis-girault opened this issue Dec 12, 2023 · 2 comments · May be fixed by #13306
Open

registerUriHandler is not implemented #13169

mathis-girault opened this issue Dec 12, 2023 · 2 comments · May be fixed by #13306
Assignees
@rschnekenbu
Labels
vscode issues related to VSCode compatibility

Comments

@mathis-girault
Copy link

Feature Description:

The function registerUriHandler is not implemented in theia.
It is defined in the VS code API.

This is needed to handle callbacks to theia through URIs, for example when creating an extension using GitHub OAuth.
@tsmaeder tsmaeder added the vscode issues related to VSCode compatibility label Dec 12, 2023
@tsmaeder
Copy link
Contributor

@rschnekenbu this API is not marked as stubbed, that's why it does not appear on the comparator output. Can we put this on the backlog for API-compat?

@mathis-girault mathis-girault mentioned this issue Jan 3, 2024
Merged
@rschnekenbu
Copy link
Contributor

@tsmaeder, I will take over this task. Can you assign it to me please? Thanks!

@msujew msujew assigned rschnekenbu and unassigned tsmaeder Jan 16, 2024
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Jan 23, 2024
@rschnekenbu
wip - Manage register URI handler (eclipse-theia#13169)
731a0c1 
contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Jan 23, 2024
@rschnekenbu
Implement stubbed window#registerURIhandler
c5e5de5 
fixes eclipse-theia#13169

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@rschnekenbu rschnekenbu mentioned this issue Jan 23, 2024
Closed
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Jan 24, 2024
@rschnekenbu
Implement stubbed window#registerURIhandler
7ea3fc1 
fixes eclipse-theia#13169

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@rschnekenbu rschnekenbu linked a pull request Jan 24, 2024 that will close this issue
Open
2 tasks
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Jan 24, 2024
@rschnekenbu
Implement stubbed window#registerURIhandler
98d8f0c 
fixes eclipse-theia#13169

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@mathis-girault mathis-girault mentioned this issue Feb 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rschnekenbu rschnekenbu

Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement previously stubbed window#registerURIhandler (#13169) eclipsesource/theia
3 participants
@rschnekenbu @tsmaeder @mathis-girault