You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What are your thouhgts on refactoring the serializers to pydantic instead of marshmallow? I would be happy to make a PR if you thought it woudl be useful.
It would be advantageous to get the proper types instead of relying on default getters. This would simplify refactoring and provide extra safety.
Better configuration parsing.
Currently configuration must come from config.yaml and environment variables. For improved flexibility and testing ergonomics it would be nice to to set configuration from a config.yaml with environment variable overrides. Pydantic's settings management is both powerful and flexible.
Generating pydantic models from 3rd party (confluence/jira/opsgenie/pagerduty) apis will also improve DX + type safety.
Love to hear your thoughts :).
The text was updated successfully, but these errors were encountered:
@uptickmetachu sorry it took me a bit to get back to you - honestly, after doing some work on a project I just built, it might even be worth implementing FastAPI in-place of the bespoke Flask implementation which would also make it easier to implement Pydantic models. Any thoughts?
What are your thouhgts on refactoring the serializers to
pydantic
instead of marshmallow? I would be happy to make a PR if you thought it woudl be useful.https://docs.pydantic.dev/latest/
I can see several benefits:
It would be advantageous to get the proper types instead of relying on default getters. This would simplify refactoring and provide extra safety.
Better configuration parsing.
Currently configuration must come from
config.yaml
and environment variables. For improved flexibility and testing ergonomics it would be nice to to set configuration from a config.yaml with environment variable overrides. Pydantic's settings management is both powerful and flexible.Generating pydantic models from 3rd party (confluence/jira/opsgenie/pagerduty) apis will also improve DX + type safety.
Love to hear your thoughts :).
The text was updated successfully, but these errors were encountered: