Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider Structure and Vacant #343

Open
0ncorhynchus opened this issue May 9, 2019 · 0 comments
Open

Reconsider Structure and Vacant #343

0ncorhynchus opened this issue May 9, 2019 · 0 comments
Assignees

Comments

@0ncorhynchus
Copy link
Collaborator

The name Structure is confusing because its implementation differs from its name.

The major difference between MoleculePool and StructureType is whether to store coordinates or not.
In addition to this, StructureType have constant values: D = 0.0 and pid = ParticleID(0, 0).
This causes that the particles can't have own ParticleIDs in the case some may want to use StructureType only to ignore particles for tracking.

This is the reason that I propose to rename StructureType with another name (e.g. NoTrackingType) and reimplement it.

Finally, Vacant is also confusing and its attributes are meaningless.
So, we can replace it with null_ptr (because we use them as shared_ptr<VoxelPool> or raw pointers).

related to #334.

@0ncorhynchus 0ncorhynchus self-assigned this Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant