Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version identification #331

Open
kaizu opened this issue Feb 25, 2019 · 7 comments
Open

Version identification #331

kaizu opened this issue Feb 25, 2019 · 7 comments

Comments

@kaizu
Copy link
Member

kaizu commented Feb 25, 2019

Determine the style of version naming.

The following documents gives the style for Python packages though it seems too complicated.
https://www.python.org/dev/peps/pep-0440/

The version style affects the following part:

https://github.com/ecell/ecell4-base/blob/master/ecell4/core/extras.hpp#L90-L101
https://github.com/ecell/ecell4-base/blob/master/ecell4/core/extras.cpp#L103-L168

@kaizu
Copy link
Member Author

kaizu commented Feb 25, 2019

The project version is given here: https://github.com/ecell/ecell4-base/blob/master/CMakeLists.txt#L4

This also works as the version of Python pacage ecell4_base. Thus, it must be consistent with the style.

@kaizu
Copy link
Member Author

kaizu commented Feb 25, 2019

The version scheme in PEP 440 is [N!]N(.N)*[{a|b|rc}N][.postN][.devN].

The current implementation only accepts N.N.N.

Here is a proposal: N.N.[dev]N

  • No epoch
  • At least two release numbers are required.
  • Third release number is replaceable with a development release segment.

This accepts 1.0.dev2, but omit several styles such as 1.0.1.dev1, 1.0b2 and 1.0.post1.

@kaizu
Copy link
Member Author

kaizu commented Feb 25, 2019

Or simply N.N[.devN]. Just two release numbers and one optional development segment.

@kaizu kaizu added this to the v1.0.0 milestone Feb 25, 2019
@kaizu
Copy link
Member Author

kaizu commented Feb 25, 2019

kaizu added a commit to kaizu/ecell4_base that referenced this issue Feb 25, 2019
@kaizu
Copy link
Member Author

kaizu commented Feb 28, 2019

Use N.N[.devN]: 1.0.dev1 -> 1.0.dev2 -> 1.0 -> 1.1.dev1 -> ...

kaizu added a commit to kaizu/ecell4_base that referenced this issue Mar 1, 2019
kaizu added a commit to kaizu/ecell4_base that referenced this issue Mar 1, 2019
@kaizu kaizu mentioned this issue Mar 1, 2019
kaizu added a commit to kaizu/ecell4_base that referenced this issue Mar 1, 2019
kaizu added a commit to kaizu/ecell4_base that referenced this issue Mar 1, 2019
kaizu added a commit that referenced this issue Mar 1, 2019
* #331 Update the version scheme
* #331 Update the minimum version required
@kaizu
Copy link
Member Author

kaizu commented Mar 1, 2019

The version scheme expects N.N[.N][.devN] to support the old style.

@kaizu kaizu closed this as completed Mar 1, 2019
@kaizu kaizu mentioned this issue Mar 3, 2019
@kaizu kaizu reopened this Mar 9, 2019
@kaizu
Copy link
Member Author

kaizu commented Mar 9, 2019

The version scheme was updated: N.N.N[{a|b}N] where the micro version must be 0 when {a|b}N is given.

  • The major, minor and micro version must be always given. Never omit the micro version.
  • No dev is allowed.

kaizu added a commit to kaizu/ecell4_base that referenced this issue Mar 11, 2019
kaizu added a commit to kaizu/ecell4_base that referenced this issue Mar 11, 2019
kaizu added a commit to kaizu/ecell4_base that referenced this issue Mar 11, 2019
kaizu added a commit to kaizu/ecell4_base that referenced this issue Mar 11, 2019
kaizu added a commit to kaizu/ecell4_base that referenced this issue Mar 11, 2019
kozo2 pushed a commit that referenced this issue May 21, 2019
* #331 Enable pre-release

* #331 Use unsigned int

* #331 Modify enum path

* #331 Avoid default template argument

* #331 Modify enum path again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants